add validation for options passes to MakeDocs

[anonymous]

the cli-application "MakeDocs?" uses a default of "/" for both options "class-dir" and "package-dir", as returned by Solar_Dir::fix(null)..

Setting those to 'require' => true, 'param' => 'required' fixes that problem.

additionaly, line 741 evaluates to true if a file with that name exists, making mkdir throw a warning. fixed too.

[zined]

options.php.diff

[zined]

MakeDocs?.php.diff

[pmjones]

(In [3382]) Solar_Cli_MakeDocs: [FIX] Make the class and package dirs options required. Thanks, Zined.

refs #152

[pmjones]

Zined, I have a question about the second part of your report. When I do this:

touch tempfile
php -r "var_dump(is_dir('./tempfile'));"

I get bool(false), which is correct. Can you tell me how to duplicate the error you're seeing in relation to file_exists()/is_dir() differences?

[zined@…]

Hi Paul,

it's not is_dir() not working correct, but just beeing imho wrong in that place:

having a file "/foo", is_dir("/foo") returning false, calling mkdir("/foo") shouldn't be performed if i don't get this wrong.

greetingz